qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwray <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #:
Date Fri, 05 May 2017 15:01:46 GMT
Github user dwray commented on the pull request:

    https://github.com/apache/qpid-proton/commit/a61f50e94ceb74ed81665192e1d3051ec8be0208#commitcomment-22033928
  
    Your update didn't work for me.  It looks like the TrimPrefix expression is back to front,
swapping it round to: addr := strings.TrimPrefix(url.Path, "/") fixed it.
    
    See: https://golang.org/pkg/strings/#TrimPrefix 
    func TrimPrefix
    
    func TrimPrefix(s, prefix string) string
    TrimPrefix returns s without the provided leading prefix string. If s doesn't start with
prefix, s is returned unchanged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message