qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1407) pn_collector_next and pn_collector_peek are inconsistent
Date Tue, 09 May 2017 15:50:04 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002923#comment-16002923
] 

ASF subversion and git services commented on PROTON-1407:
---------------------------------------------------------

Commit bfa8a71e3161a0f687fbe4b0584d6dc0ab3ccae4 in qpid-proton's branch refs/heads/master
from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bfa8a71 ]

PROTON-1460: epoll - remove un-necessary event_cache fields

The event_cache was required to work around bug PROTON-1407 in
collector_peek()/collector_next() but that is fixed since commit 7368c34


> pn_collector_next and pn_collector_peek are inconsistent
> --------------------------------------------------------
>
>                 Key: PROTON-1407
>                 URL: https://issues.apache.org/jira/browse/PROTON-1407
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.17.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>             Fix For: 0.18.0
>
>
> pn_collector_peek() == NULL is not a reliable test for an empty collector if you use
pn_collector_next(). next() leaves the event on the head of the queue until the following
call to next, which is confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message