qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7723) [0-10] Re-encoding of the 0-10 message during computation of updateStatsOnEnqueue causes performance slow down
Date Tue, 23 May 2017 09:04:05 GMT

    [ https://issues.apache.org/jira/browse/QPID-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020907#comment-16020907

ASF subversion and git services commented on QPID-7723:

Commit 18bd89e753d7b4759dfcdb1d118e6a07af6940bf in qpid-broker-j's branch refs/heads/6.1.x
from [~lorenz.quack]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=18bd89e ]

Revert "QPID-7723: [0-10] Allow header to be optional when computing the encoded size"

This reverts commit 400e7ec7090fd2135996a43343e885889adfd78d.

> [0-10] Re-encoding of the 0-10 message during computation of updateStatsOnEnqueue causes
performance slow down
> --------------------------------------------------------------------------------------------------------------
>                 Key: QPID-7723
>                 URL: https://issues.apache.org/jira/browse/QPID-7723
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-broker-7.0.0
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: qpid-java-6.0.7, qpid-java-broker-7.0.0, qpid-java-6.1.3
>         Attachments: hotspot_comparison.tar.bz2
> We are seeing a slowdown in the Java Broker for the 0-10 protocol since February 2017.
 Investigation with JProfiler is pointing to the introduction of the ring queue feature as
being a possible cause.   The performance drop is most apparent with on the transient profiles,
where the drop is around ~2-3%.
> The problem is the new call to MessageMetaData_0_10#getStorableSize made from AbstractQueueEntryList#updateStatsOnEnqueue.
On the 0-10 path, this causes the header delivery properties/message properties/non standard
delivery properties to be encoded in order to compute the store size.  This encoding step
is separate to the encoding step that takes place when the message is sent to a consumer.
 The up shot is that the headers for a transient message that is not flown to disk are now
encoded twice rather than once.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message