qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1450) Add Filter LinkOption to Electron API
Date Wed, 31 May 2017 21:30:04 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031996#comment-16031996
] 

Alan Conway commented on PROTON-1450:
-------------------------------------

The above commit adds the type safe amqp.Key type and type safe methods to correctly manipulate
and encode amqp.Message maps. 

I have also fixed PROTON-1456 (described type support). The AMQP spec says filters should
use described types, but the filter support in electron will not enforce that: if your AMQP
service accepts non-described types in a filter map that will still be supported.

I will add the actual filter support shortly to complete this issue, using map[Symbol]interface{}
as the filter type, so you would do something like
    filter[Symbol("foo")] = "filter-data"
or  
    filter[Symbol("foo")] = Described{Symbol("filter-descriptor"), "filter-data"}
etc.

> Add Filter LinkOption to Electron API
> -------------------------------------
>
>                 Key: PROTON-1450
>                 URL: https://issues.apache.org/jira/browse/PROTON-1450
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: go-binding
>            Reporter: Kale Blankenship
>            Assignee: Alan Conway
>
> There doesn't appear to be a way to set filters with the current Go bindings. Microsoft's
Event Hubs use filters to indicate the starting offset of messages (http://azure.github.io/amqpnetlite/articles/azure_eventhubs.html#filter).
Without this option it would be difficult to properly use the bindings with Event Hubs.
> There is a wrapper which patches the bindings to provide the functionality here: https://github.com/recobe182/gohub.
Though I am not familiar enough with Qpid to determine if the patch is reasonable.
> Thank you for considering this request and creating/maintaining this project!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message