qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-780) When link is disallowed due to target/source name it should not return amqp:resource-limit-exceeded
Date Thu, 25 May 2017 09:29:04 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024451#comment-16024451
] 

ASF GitHub Bot commented on DISPATCH-780:
-----------------------------------------

GitHub user scholzj opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/164

    DISPATCH-780 - Send amqp:unauthorized-access when link is disallowed because of target
/ source name

    Added a new parameter to methods `_qd_policy_deny_amqp_link`, `_qd_policy_deny_amqp_sender_link`
and `_qd_policy_deny_amqp_receiver_link`. 
    
    This allows to pass the correct error condition from `qd_policy_approve_amqp_sender_link`
or  `qd_policy_approve_amqp_receiver_link` and send it to thew client when the link is closed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scholzj/qpid-dispatch DISPATCH-780

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164
    
----
commit 191843190f7a535ff707a5209a166248f24e64aa
Author: Jakub Scholz <jakub@scholz.cz>
Date:   2017-05-25T08:00:11Z

    Use _qd_policy_deny_amqp_sender_link when denying sender link

commit 6e09494502b9abd3d56f32a782b28e366de8da03
Author: Jakub Scholz <jakub@scholz.cz>
Date:   2017-05-25T08:22:55Z

    Use proper error condition when the link is denied

----


> When link is disallowed due to target/source name it should not return amqp:resource-limit-exceeded
> ---------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-780
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-780
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Jakub Scholz
>             Fix For: 1.0.0
>
>
> It seems that today, when link creation is denied by the policy, it always returns {{amqp:resource-limit-exceeded}}
error. That is valid when the link is rejected because exceeding the number of senders / receivers
specified in the policy. However, this doesn't seem to be the correct error when the link
creation is not allowed because the target/source name is not allowed. In such case, {{amqp:unauthorized-access}}
seems to be more appropriate.
> Additionally, it looks like in {{policy.c}} the function {{qd_policy_approve_amqp_sender_link}}
calls on several places {{_qd_policy_deny_amqp_receiver_link}} instead of {{_qd_policy_deny_amqp_sender_link}}.
> I will try to provide some PR with suggested fix.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message