qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7739) [Java Broker] In AMQP 1.0 fix handling of channel Id > 2^15
Date Mon, 05 Jun 2017 16:26:04 GMT

    [ https://issues.apache.org/jira/browse/QPID-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037165#comment-16037165
] 

ASF subversion and git services commented on QPID-7739:
-------------------------------------------------------

Commit 5a872b43176c054ae58272f161f7337b5c4d2200 in qpid-broker-j's branch refs/heads/master
from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=5a872b4 ]

QPID-7739 : [Java Broker] [AMQP 1.0] Use correct types in operations with performative fields

* use int for channel id
* avoid setting of negative maxFrameSize (enforce maxFrameSize to be less than networkBufferSize)
* in comparison operations for Disposition#first and Disposition#last use SequenceNumber


> [Java Broker] In AMQP 1.0 fix handling of channel Id > 2^15
> -----------------------------------------------------------
>
>                 Key: QPID-7739
>                 URL: https://issues.apache.org/jira/browse/QPID-7739
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Lorenz Quack
>             Fix For: qpid-java-broker-7.0.0
>
>
> In AMQP 1.0 the channel ID is an Unsigned Short, i.e. 0 <= x < 2^16
> However in the amqp 1.0 plugin the channel is modeled as a java short which is signed
and thus in the range -2^15 <= x < 2^15.
> This causes some problems if the channel id exceeds 2^15. Some issues are minor like
the error statement in {{AMQPConnection_1_0Impl#getSession}} taking on a negative value but
some will be more unfortunate like the {{ArrayIndexOutOfBoundsException}} earlier in the same
method (will fail the session Begin and close the connection).
> There are several possible solutions:
>  * handle the unsigned short correctly (either as UnsignedShort or as int)
>  * enforce a max-channel of 2^15 - 1 on connection Open



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message