qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-788) Create peer linkage for presettled deliveries so we can use this to handle muticast dispositions
Date Tue, 20 Jun 2017 16:02:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056011#comment-16056011
] 

ASF GitHub Bot commented on DISPATCH-788:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/167#discussion_r123020082
  
    --- Diff: src/router_core/router_core_private.h ---
    @@ -693,6 +694,28 @@ void qdr_delivery_release_CT(qdr_core_t *core, qdr_delivery_t *delivery);
     void qdr_delivery_failed_CT(qdr_core_t *core, qdr_delivery_t *delivery);
     bool qdr_delivery_settled_CT(qdr_core_t *core, qdr_delivery_t *delivery);
     void qdr_delivery_decref_CT(qdr_core_t *core, qdr_delivery_t *delivery);
    +
    +/**
    + * Links the in_dlv to the out_dlv and increments ref counts of both deliveries
    + */
    +void qdr_delivery_link_peers_CT(qdr_delivery_t *in_dlv, qdr_delivery_t *out_dlv);
    +
    +/**
    + * Zeroes out peer references from both peers and decrefs ref counts.
    + */
    +void qdr_delivery_unlink_peers_CT(qdr_core_t *core, qdr_delivery_t *dlv, qdr_delivery_t
*peer);
    +
    +/**
    + * Called before the call to qdr_delivery_next_peer_CT. This positions the peer pointer
to the first peer position.
    --- End diff --
    
    The comments for qdr_delivery_{first,next}_peer are incorrect.


> Create peer linkage for presettled deliveries so we can use this to handle muticast dispositions
> ------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-788
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-788
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 0.8.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
>
>
> Right now peer delivieries are not created for presettled messages. Create peers for
presettled messages so that this feature can be used to implement several features like message
streaming, handling multicast dispositions etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message