qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPIDJMS-303) Add support for SASL GSSAPI Kerberos mechanism
Date Fri, 21 Jul 2017 13:15:00 GMT

    [ https://issues.apache.org/jira/browse/QPIDJMS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096226#comment-16096226
] 

ASF GitHub Bot commented on QPIDJMS-303:
----------------------------------------

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-jms/pull/10#discussion_r128726699
  
    --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java
---
    @@ -137,7 +142,9 @@ private void handleSaslStep() throws JMSSecurityException {
                     byte[] challenge = new byte[sasl.pending()];
                     sasl.recv(challenge, 0, challenge.length);
                     byte[] response = mechanism.getChallengeResponse(challenge);
    -                sasl.send(response, 0, response.length);
    +                if (response != null) {
    --- End diff --
    
    Did you need this null check? The SASL process is likely to hang if there is no response
to a challenge. I think its reasonable to require one be given, or fail if there isn't and
an exception isn't thrown.


> Add support for SASL GSSAPI Kerberos mechanism
> ----------------------------------------------
>
>                 Key: QPIDJMS-303
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-303
>             Project: Qpid JMS
>          Issue Type: Bug
>          Components: qpid-jms-client
>            Reporter: Gary Tully
>
> It would be great to be able to authenticate using kerberos credentials using the SASL
GSSAPI mechanism.
> Authentication would be sufficient leaving TLS to do encryption of the channel if that
is necessary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message