qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPIDJMS-303) Add support for SASL GSSAPI Kerberos mechanism
Date Tue, 25 Jul 2017 16:21:00 GMT

    [ https://issues.apache.org/jira/browse/QPIDJMS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100301#comment-16100301
] 

ASF GitHub Bot commented on QPIDJMS-303:
----------------------------------------

Github user gtully commented on a diff in the pull request:

    https://github.com/apache/qpid-jms/pull/10#discussion_r129354263
  
    --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java
---
    @@ -0,0 +1,190 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.qpid.jms.sasl;
    +
    +import javax.security.auth.Subject;
    +import javax.security.auth.login.AppConfigurationEntry;
    +import javax.security.auth.login.Configuration;
    +import javax.security.auth.login.LoginContext;
    +import javax.security.sasl.Sasl;
    +import javax.security.sasl.SaslClient;
    +import javax.security.sasl.SaslException;
    +import java.security.Principal;
    +import java.security.PrivilegedActionException;
    +import java.security.PrivilegedExceptionAction;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * Implements the GSSAPI sasl authentication Mechanism.
    + */
    +public class GssapiMechanism extends AbstractMechanism {
    +
    +    public static final String NAME = "GSSAPI";
    +    private Subject subject;
    +    private SaslClient saslClient;
    +    private String protocol = "amqp";
    +    private String serverName = null;
    +    private String configScope = null;
    +
    +    // a gss/sasl service name, x@y, morphs to a krbPrincipal a/y@REALM
    +
    +    @Override
    +    public int getPriority() {
    +        return PRIORITY.LOW.getValue();
    +    }
    +
    +    @Override
    +    public String getName() {
    +        return NAME;
    +    }
    +
    +    @Override
    +    public byte[] getInitialResponse() throws SaslException {
    +        try {
    +            LoginContext loginContext = null;
    +            if (configScope != null) {
    +                loginContext = new LoginContext(configScope);
    +            } else {
    +                // inline keytab config using user as principal
    +                loginContext = new LoginContext("", null, null,
    +                        kerb5InlineConfig(getUsername(), true));
    +            }
    +            loginContext.login();
    +            subject = loginContext.getSubject();
    +
    +            return Subject.doAs(subject, new PrivilegedExceptionAction<byte[]>()
{
    +
    +                @Override
    +                public byte[] run() throws Exception {
    +                    saslClient = Sasl.createSaslClient(new String[]{NAME}, null, protocol,
serverName, null, null);
    +                    if (saslClient.hasInitialResponse()) {
    +                        return saslClient.evaluateChallenge(new byte[0]);
    +                    }
    +                    return null;
    +                }
    +            });
    +        } catch (Exception e) {
    +            throw new SaslException(e.toString(), e);
    +        }
    +    }
    +
    +    @Override
    +    public byte[] getChallengeResponse(final byte[] challenge) throws SaslException {
    +        try {
    +            return Subject.doAs(subject, new PrivilegedExceptionAction<byte[]>()
{
    +                @Override
    +                public byte[] run() throws Exception {
    +                    return saslClient.evaluateChallenge(challenge);
    +                }
    +            });
    +        } catch (PrivilegedActionException e) {
    +            throw new SaslException(e.toString(), e);
    +        }
    +    }
    +
    +    @Override
    +    public void verifyCompletion() throws SaslException {
    +        boolean result = saslClient.isComplete();
    +        saslClient.dispose();
    +        if (!result) {
    +            throw new SaslException("not complete");
    +        }
    +    }
    +
    +
    +    @Override
    +    public boolean isApplicable(String username, String password, Principal localPrincipal)
{
    +        return true;
    +    }
    +
    +    private static final boolean IBM_JAVA =  System.getProperty("java.vendor").contains("IBM");
    +    public static Configuration kerb5InlineConfig(String principal, boolean initiator)
{
    +        final Map<String, String> options = new HashMap<>();
    +        if (IBM_JAVA) {
    +            options.put("principal", principal);
    +            options.put("renewable", "true");
    +            options.put("credsType", initiator ? "initiator" : "acceptor");
    +        } else {
    +            options.put("isInitiator", String.valueOf(initiator));
    +            options.put("principal", principal);
    +            options.put("useKeyTab", "true");
    +            options.put("storeKey", "true");
    +            options.put("doNotPrompt", "true");
    +            options.put("renewTGT", "true");
    +            options.put("refreshKrb5Config", "true");
    +            options.put("useTicketCache", "true");
    +            String ticketCache = System.getenv("KRB5CCNAME");
    +
    +            if (IBM_JAVA) {
    +                // If cache is specified via env variable, it takes priority
    +                if (ticketCache != null) {
    +                    // IBM JAVA only respects system property so copy ticket cache to
system property
    +                    // The first value searched when "useDefaultCcache" is true.
    +                    System.setProperty("KRB5CCNAME", ticketCache);
    --- End diff --
    
    Those conditional have been replaced with the option to provide sasl.krb5.x overrides
or additions as url parameters and if you wish fully configure the krb5 login module. 
    The default options work for a client on the sun jdk, the ibm jdk needs url params.


> Add support for SASL GSSAPI Kerberos mechanism
> ----------------------------------------------
>
>                 Key: QPIDJMS-303
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-303
>             Project: Qpid JMS
>          Issue Type: Bug
>          Components: qpid-jms-client
>            Reporter: Gary Tully
>
> It would be great to be able to authenticate using kerberos credentials using the SASL
GSSAPI mechanism.
> Authentication would be sufficient leaving TLS to do encryption of the channel if that
is necessary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message