qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gberginc <...@git.apache.org>
Subject [GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL
Date Wed, 23 Aug 2017 07:06:32 GMT
Github user gberginc commented on the issue:

    https://github.com/apache/qpid-proton/pull/116
  
    @alanconway initially, I was using the gem from the rubygems link you mentioned, yes.
I am looking forward to the new published version. Until then, I will host the gem at https://github.com/gberginc/qpid_proton_gem
for I need to be able to deploy it from another app.
    
    I have tested your change and it almost worked for me. I only had to apply the following
patch:
    ```
    diff --git a/proton-c/bindings/ruby/lib/core/url.rb b/proton-c/bindings/ruby/lib/core/url.rb
    index 39b64650..195567f2 100644
    --- a/proton-c/bindings/ruby/lib/core/url.rb
    +++ b/proton-c/bindings/ruby/lib/core/url.rb
    @@ -84,6 +84,6 @@ end
     class String
       # Convert this string to a URL
       def to_url()
    -    return URL.new(self)
    +    return Qpid::Proton::URL.new(self)
       end
     end
    ```
    
    Not sure if this is because I am using the code from outside of the gem itself, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message