qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
Date Wed, 23 Aug 2017 17:27:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138692#comment-16138692
] 

ASF GitHub Bot commented on DISPATCH-802:
-----------------------------------------

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/190

    DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:prec…

    …ondition-failed. 2. Modified error description 3. Prevented from setting the target
on the return attach

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-802-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #190
    
----
commit 667fab3282a20c96e2a741914b8cbfedd075d041
Author: Ganesh Murthy <gmurthy@redhat.com>
Date:   2017-08-23T17:23:41Z

    DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:precondition-failed.
2. Modified error description 3. Prevented from setting the target on the return attach

----


> refuse transaction coordination links if they can't be routed to a coordinator
> ------------------------------------------------------------------------------
>
>                 Key: DISPATCH-802
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-802
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Robbie Gemmell
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support from DISPATCH-195
is not being used to link-route them somewhere that can handle coordination. If the router
can't link-route to a coordinator, and knows it can't coordinate transactions itself, it shouldn't
accept the links to begin with but rather refuse them so clients know they will never work
and why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to declare transactions.
From 0.8.0 no credit is given since there is no receiver, so clients have no way to use the
accepted link and no indication why.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message