qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-803) refuse attach to undefined addresses
Date Wed, 09 Aug 2017 19:23:04 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120503#comment-16120503
] 

ASF GitHub Bot commented on DISPATCH-803:
-----------------------------------------

Github user grs commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/185#discussion_r132281323
  
    --- Diff: src/router_core/transfer.c ---
    @@ -634,6 +634,23 @@ static void qdr_link_forward_CT(qdr_core_t *core, qdr_link_t *link,
qdr_delivery
                 addr->deliveries_ingress++;
             link->total_deliveries++;
         }
    +    //
    +    // There is no address that we can send this delivery to, which means the addr was
not found in our hastable. This
    +    // can be because there were no receivers or because the address was not defined
in the config file.
    +    // If the treatment for such addresses is set to be forbidden, we send back a rejected
disposition and detach the link
    +    //
    +    else if (core->qd->treatment == QD_TREATMENT_LINK_FORBIDDEN) {
    +        dlv->disposition = PN_REJECTED;
    +        dlv->error = qdr_error("qd:forbidden", "Sending deliveries to this address
is forbidden");
    --- End diff --
    
    Or perhaps even better would be amqp:not-found, since we are really saying that this is
not a recognised address?


> refuse attach to undefined addresses
> ------------------------------------
>
>                 Key: DISPATCH-803
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-803
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Gordon Sim
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
>
>
> At present, if you attach to an address in the router whose semantics have not been specifically
defined, you get balanced message routing semantics.
> It would be useful to be able to configure the router such that it would refuse links
whose source/target was not explicitly defined. E.g. by being able to configure the default
semantics to be of type 'invalid' (or anything similar). (Being able to explicitly blacklist
certain addresses might also be nice, but is a more exotic use case I think).
> Messages sent through an anonymous link to these 'invalid' addresses would be rejected.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message