qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdanekrh <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings
Date Tue, 05 Sep 2017 16:17:03 GMT
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/119#discussion_r137037295
  
    --- Diff: proton-c/src/proactor/libuv.c ---
    @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() {
       pn_proactor_t *p = (pn_proactor_t*)calloc(1, sizeof(pn_proactor_t));
       p->collector = pn_collector();
       p->batch.next_event = &proactor_batch_next;
    -  if (!p->collector) return NULL;
    +  if (!p->collector) {
    +    free(p);
    --- End diff --
    
    I thought of that, but then decided to keep changes to a minimum. Will you move it or
should I resubmit the PR? I'd be OK if you just committed it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message