qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdanekrh <...@git.apache.org>
Subject [GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings
Date Tue, 05 Sep 2017 20:42:31 GMT
Github user jdanekrh commented on the issue:

    https://github.com/apache/qpid-proton/pull/119
  
    @michaelandrepearce I went through some of the 1566 messages I got from CppCheck 1.80
(by category, I did not look into each in detail) and it seems to me that most of ones in
the Error category are probably valid, except `Uninitialized struct member: bytes.{start,size}`
(and I did not look into perlPERL_wrap.c). Many in the Warning category seem to be valid,
too, except when it does not understand the SCNi64 macros. That is about 50 issues in total.
The Info level messages are worth thinking about too, but probably not right now.
    
    So, all in all, the tool works pretty well, I'd say. And while I am not a big fan of KDevelop,
the integration with CppCheck is simple, but very hepful (clicking a message jumps me to the
relevant code).
    
    We should IMO consider checking in a suppression file for CppCheck, which would allow
ignoring existing nonserious issues, and make new issues stand out more in the output.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message