qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1369) Add deprecation warnings to the C++ binding
Date Tue, 26 Sep 2017 18:20:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181269#comment-16181269
] 

ASF GitHub Bot commented on PROTON-1369:
----------------------------------------

GitHub user ssorj opened a pull request:

    https://github.com/apache/qpid-proton/pull/120

    PROTON-1369: Add deprecation warnings to the C++ binding

    Changes
    
     - Add warnings for default_container.hpp, function.hpp, url.hpp, and some methods in
value.hpp
     - Removed some deprecated type conversion functions that were never published as API
     - Convert examples that used the URL class to instead split the connection URL and address
into two args
     - Some minor example improvements
    
    Notes and questions
    
     - This approach requires users define PN_CPP_USE_DEPRECATED_API if they want to carry
on without moving to the preferred APIs.
        - The alternative is #pragma message (just a warning), but that's not as portable
as #error.  #warning is regrettably non-standard.
     - I'm using #define PN_CPP_USE_DEPRECATED_API/#undef for internal uses - what's the other
approach?  I remember a recommendation to use an ORed set of internal variables, but I unfortunately
lost the details.
     - I wasn't able to find the cmake support for deprecation macros.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssorj/qpid-proton ssorj-deprecations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #120
    
----
commit d5f17b9e7b8021e7e8a5614ba92cda5f8ed80def
Author: Justin Ross <jross@apache.org>
Date:   2017-09-26T17:53:48Z

    PROTON-1369: Add deprecation warnings

----


> Add deprecation warnings to the C++ binding
> -------------------------------------------
>
>                 Key: PROTON-1369
>                 URL: https://issues.apache.org/jira/browse/PROTON-1369
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Ken Giusti
>            Assignee: Justin Ross
>            Priority: Trivial
>              Labels: api
>             Fix For: proton-c-0.18.0
>
>
> Once PROTON-225 is implemented, we should eventually remove the old interfaces after
marking them deprecated.
> Example:
> #ifdef __GNUC__
> #define DEPRECATED(func) func __attribute__ ((deprecated))
> #elif defined(_MSC_VER)
> #define DEPRECATED(func) __declspec(deprecated) func
> #else
> #pragma message("WARNING: You need to implement DEPRECATED for this compiler")
> #define DEPRECATED(func) func
> #endif



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message