qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1369) Add deprecation warnings to the C++ binding
Date Tue, 26 Sep 2017 19:39:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181418#comment-16181418
] 

ASF GitHub Bot commented on PROTON-1369:
----------------------------------------

Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/120
  
    I'm not sure that it's actually worth putting out deprecation messages for including the
files but not using the deprecated APIs there.
    
    If the APIs aren't used it will be trivial for anyone to just remove the ``#include``
when the header files are actually removed.


> Add deprecation warnings to the C++ binding
> -------------------------------------------
>
>                 Key: PROTON-1369
>                 URL: https://issues.apache.org/jira/browse/PROTON-1369
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Ken Giusti
>            Assignee: Justin Ross
>            Priority: Trivial
>              Labels: api
>             Fix For: proton-c-0.18.0
>
>
> Once PROTON-225 is implemented, we should eventually remove the old interfaces after
marking them deprecated.
> Example:
> #ifdef __GNUC__
> #define DEPRECATED(func) func __attribute__ ((deprecated))
> #elif defined(_MSC_VER)
> #define DEPRECATED(func) __declspec(deprecated) func
> #else
> #pragma message("WARNING: You need to implement DEPRECATED for this compiler")
> #define DEPRECATED(func) func
> #endif



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message