qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7892) [Java Broker] Qpid Logback plugin RollingPolicyDecorator tests fail since java.io.tmpdir pointed at directory containing parentheses
Date Mon, 04 Sep 2017 11:29:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152491#comment-16152491
] 

Keith Wall commented on QPID-7892:
----------------------------------

Wouldn't it be simpler to use http://docs.oracle.com/javase/6/docs/api/java/util/regex/Pattern.html#quote%28java.lang.String%29
rather than implementing your own regex escaping?  

> [Java Broker] Qpid Logback plugin RollingPolicyDecorator tests fail since java.io.tmpdir
pointed at directory containing parentheses 
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7892
>                 URL: https://issues.apache.org/jira/browse/QPID-7892
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Tests
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>            Priority: Minor
>
> Currently on master the following tests are failing on Apache CI.  The fails started
at the point {{$\{java.io.tmpdir\}}} was reassigned to the Jenkins job's workspace directory.
  The workspace directory contains a pair of parentheses.   The following tests are affected:
> {noformat}
> org.apache.qpid.server.logging.logback.RollingPolicyDecoratorTest.testSequentialRollover
> org.apache.qpid.server.logging.logback.RollingPolicyDecoratorTest.testRolloverRescanLimit
> org.apache.qpid.server.logging.logback.RollingPolicyDecoratorTest.testRolloverWithFile
> {noformat}
> I can see the issue is occurring because the regex match within {{org.apache.qpid.server.logging.logback.RollingPolicyDecorator.ScanTask#scan}}
is treating the parentheses as regex meta characters and this is causing the test to fail.
> I do not yet understand if this issue is a simple a test one, or whether core code is
affected.
> {{Pattern.escape}} can be used to escape regex metacharacters. Perhaps it should be used??



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message