qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrisrichardson77 <...@git.apache.org>
Subject [GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review
Date Wed, 11 Oct 2017 10:42:26 GMT
Github user chrisrichardson77 commented on a diff in the pull request:

    https://github.com/apache/qpid-cpp/pull/10#discussion_r143968869
  
    --- Diff: src/qpid/broker/Selector.cpp ---
    @@ -108,7 +108,7 @@ MessageSelectorEnv::MessageSelectorEnv(const Message& m) :
     
     const Value MessageSelectorEnv::specialValue(const string& id) const
     {
    -    Value v;
    +    Value v = Value();
    --- End diff --
    
    The original version of this is correct and invokes the default constructor.
    The new version is incorrect - it default-constructs a temporary which is copied/moved/elided
(depending on compiler version and standard) to v.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message