qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrisrichardson77 <...@git.apache.org>
Subject [GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review
Date Wed, 11 Oct 2017 10:42:26 GMT
Github user chrisrichardson77 commented on a diff in the pull request:

    https://github.com/apache/qpid-cpp/pull/10#discussion_r143969360
  
    --- Diff: src/qpid/broker/SelectorExpression.cpp ---
    @@ -1036,7 +1036,7 @@ Expression* unaryArithExpression(Tokeniser& tokeniser)
     Expression* parseExactNumeric(const Token& token, bool negate)
     {
         int base = 0;
    -    string s;
    +    string s("");
    --- End diff --
    
    Not necessary as std::string's default constructor already assigns an empty string.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message