qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrisrichardson77 <...@git.apache.org>
Subject [GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review
Date Wed, 11 Oct 2017 10:42:27 GMT
Github user chrisrichardson77 commented on a diff in the pull request:

    https://github.com/apache/qpid-cpp/pull/10#discussion_r143973175
  
    --- Diff: src/qpid/broker/SelectorToken.h ---
    @@ -69,7 +69,8 @@ struct Token {
         std::string val;
         std::string::const_iterator tokenStart;
     
    -    Token()
    +    Token() :
    +        type()
    --- End diff --
    
    The base type of an enum is a primitive integral type so it is correct to initialise it
here. However "type()" will assign zero to the variable irrespective of whether that is a
valid enum element - perhaps better to explicitly assign an enum element eg: type(T_EOS) (if
that was the intention) or type(T_NULL).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message