qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrisrichardson77 <...@git.apache.org>
Subject [GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review
Date Wed, 11 Oct 2017 10:42:27 GMT
Github user chrisrichardson77 commented on a diff in the pull request:

    https://github.com/apache/qpid-cpp/pull/10#discussion_r143969055
  
    --- Diff: src/qpid/broker/Selector.cpp ---
    @@ -165,8 +165,6 @@ const Value MessageSelectorEnv::specialValue(const string& id)
const
                 returnedStrings.push_back(new string(jmsType));
                 v = returnedStrings[returnedStrings.size()-1];
             }
    -    } else {
    -        v = Value();
    --- End diff --
    
    Correct (for the record), should be removed irrespective of above initialisation


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message