qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdanekrh <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...
Date Tue, 24 Oct 2017 12:09:30 GMT
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/127#discussion_r146538625
  
    --- Diff: proton-c/bindings/javascript/module.js ---
    @@ -327,7 +327,7 @@ Module.EventDispatch = new function() { // Note the use of new to
create a Singl
                  * actually free and remove the selectable is deferred until next
                  * time round the (internal JavaScript) event loop. This turned out
                  * to be necessary because in some cases the ws WebSocket library
    -             * calls the onclose callback (concurrently!!) before the onmessage
    +             * calls the on_close callback (concurrently!!) before the on_message
    --- End diff --
    
    couldn't find what are correct names for these callbacks, maybe I got it wrong


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message