qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1369) Add deprecation warnings to the C++ binding
Date Wed, 11 Oct 2017 00:05:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199596#comment-16199596
] 

ASF GitHub Bot commented on PROTON-1369:
----------------------------------------

Github user ssorj commented on the issue:

    https://github.com/apache/qpid-proton/pull/120
  
    Changes made per the review.
    
    I took part of the logic from the cmake deprecation macro, but kept some of the conditions
from the previous iteration because they are more consistent with the rest of the defines
in export.hpp.
    
    I will squash these before commit.


> Add deprecation warnings to the C++ binding
> -------------------------------------------
>
>                 Key: PROTON-1369
>                 URL: https://issues.apache.org/jira/browse/PROTON-1369
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Ken Giusti
>            Assignee: Justin Ross
>            Priority: Trivial
>              Labels: api
>             Fix For: proton-c-0.18.0
>
>
> Once PROTON-225 is implemented, we should eventually remove the old interfaces after
marking them deprecated.
> Example:
> #ifdef __GNUC__
> #define DEPRECATED(func) func __attribute__ ((deprecated))
> #elif defined(_MSC_VER)
> #define DEPRECATED(func) __declspec(deprecated) func
> #else
> #pragma message("WARNING: You need to implement DEPRECATED for this compiler")
> #define DEPRECATED(func) func
> #endif



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message