qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7646) [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support values > 1
Date Wed, 25 Oct 2017 09:36:02 GMT

    [ https://issues.apache.org/jira/browse/QPID-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218299#comment-16218299
] 

Rob Godfrey commented on QPID-7646:
-----------------------------------

So, when I think of open transactions on a session I would probably consider it to be "the
number of distinct transactions with which non-committed work on this session has been associated";
as such the sum number of open transactions on each session might actually be greater than
the total number of open transactions for the connection.  The session on which the link to
the transactional controller is opened is not terribly interesting (one could use a dedicated
session for creating/committing all transactions, but do all the transactional work on different
sessions... in this case I argue that it is the sessions with ongoing transactional work that
is interesting).

> [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support values >
1
> -----------------------------------------------------------------------------------
>
>                 Key: QPID-7646
>                 URL: https://issues.apache.org/jira/browse/QPID-7646
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Lorenz Quack
>             Fix For: qpid-java-broker-7.0.0
>
>
> During the review of QPID-7633 it was noted:
> bq. Why do we only return 0 or 1 from AbstractAMQPSession#getLocalTransactionOpen. That
seems wrong.
> which was followed up by Rob:
> bq. On getLocalTransactionOpen, I agree that looks very dodgy. In AMQP 0-x the value
will only be 0 or 1, but I'm not sure the implementation the we have now is safe. I think
the implementations will need to define this properly (i.e. the calculation will need to be
atomic, and the value may be > 1 for AMQP 1.0 )



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message