qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection<QpidByteBuffers>
Date Wed, 18 Oct 2017 16:16:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209619#comment-16209619
] 

Rob Godfrey commented on QPID-7832:
-----------------------------------

This looks like it could be quite a substantial change - would it make sense to have this
up as a branch / PR somewhere that people can see evolving?

I guess this is a general process question for whenever people are working on larger changes

> Refactor store/protocol API using Collection<QpidByteBuffers>
> -------------------------------------------------------------
>
>                 Key: QPID-7832
>                 URL: https://issues.apache.org/jira/browse/QPID-7832
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Priority: Minor
>             Fix For: qpid-java-broker-7.0.0
>
>         Attachments: 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch
>
>
> Store/protocol APIs have gradually been evolving to accept/return message content/message
metadata in terms of an ordered list of QBBs.  This has lead to use of helper methods such
as those in QBBUtils which read from a list of buffers rather than a single one.
> This would be better refactored.   QpidByteBuffer should be an interface.  This would
allow a concrete implementation CompositeQpidByteBuffer which is backed by a list produced
by the store or network IO.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message