qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7946) [Java Broker] ProtocolNegotiationTest only works by accident on AMQP 1.0
Date Mon, 02 Oct 2017 21:43:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188901#comment-16188901
] 

ASF subversion and git services commented on QPID-7946:
-------------------------------------------------------

Commit 526019c750fed803ccd16a01177009cc0bfee1ff in qpid-broker-j's branch refs/heads/master
from [~godfrer]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=526019c ]

QPID-7946 : Fix ProtocolNegotiationTest for AMQP 1.0 and Windows


> [Java Broker] ProtocolNegotiationTest only works by accident on AMQP 1.0 
> -------------------------------------------------------------------------
>
>                 Key: QPID-7946
>                 URL: https://issues.apache.org/jira/browse/QPID-7946
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>            Priority: Minor
>
> ProtocolNegotiationTest.testNoConnectionOpenSent_BrokerClosesConnection attempts to send
heartbeats to the broker after sending the first protocol header but before authenticating.
> In AMQP 1.0 you cannot send empty (heartbeat) frames while establishing a SASL layer
- empty (heartbeat) frames are only defined for AMQP frames.  To compound this error, the
test is actually sending AMQP 0-8 heartbeat frames anyway :-)
> The test also fails on Windows seemingly because windows does not report the connection
has closed unless you try to read from it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message