qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1609) build C examples with c90 flag for older compilers
Date Wed, 04 Oct 2017 00:02:15 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190565#comment-16190565
] 

ASF subversion and git services commented on PROTON-1609:
---------------------------------------------------------

Commit 433e9a0395c75ef4279a119081b253e0074b7521 in qpid-proton's branch refs/heads/master
from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=433e9a0 ]

PROTON-1609: build C examples with c90 flag for older compilers

- Get rid of // comments in public header files, not allowed in c90
- Simplify/clarify cmake variables exported from proton-c/CMakeLists for examples
- Set -std=c90 for gcc/clang example builds
- Fix examples to build with c90 - // comments and variable declarations in front


> build C examples with c90 flag for older compilers
> --------------------------------------------------
>
>                 Key: PROTON-1609
>                 URL: https://issues.apache.org/jira/browse/PROTON-1609
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: examples
>    Affects Versions: 0.17.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>             Fix For: proton-c-0.18.0
>
>
> The main proton library requires a c99 compiler (actually the overlap of c90 and c++03)
but the examples should compile with c90 to ensure they work with older compiolers.
> Fix CMakeLists to use the -std=c90 flag for examples with clang and gcc compilers, to
get early warning of c90-incompatible code in the examples.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message