qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7968) [Java Broker] [AMQP 1.0] AccessControlException thrown on authorization of connection creation is caught in FrameHandler instead of AMQPConnection_1_0Impl
Date Tue, 10 Oct 2017 12:34:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198589#comment-16198589
] 

ASF subversion and git services commented on QPID-7968:
-------------------------------------------------------

Commit 28c3dc2bc701a5d5c3d88ccea1af1dc7b783aa40 in qpid-broker-j's branch refs/heads/master
from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=28c3dc2 ]

 QPID-7968: [Java Broker][AMQP 1.0] Handle AccessControlException on authorization of connect
action


> [Java Broker] [AMQP 1.0] AccessControlException thrown on authorization of connection
creation is caught in FrameHandler instead of AMQPConnection_1_0Impl
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7968
>                 URL: https://issues.apache.org/jira/browse/QPID-7968
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Alex Rudyy
>            Priority: Minor
>
> ACL exception for opening of connection is not handled correctly.
> It is currently caught in {{FrameHandler}} and reported as internal error. It should
be caught in {{AMQPConnection}} and reported back to the client as error "amqp:not-allowed".
Here is an exception stack trace
> {noformat}
> 2017-10-10 11:39:55,590          WARN  [IO-/127.0.0.1:59709] o.a.q.s.p.v.f.FrameHandler
Unexpected exception handling frame
> java.security.AccessControlException: Permission PERFORM_ACTION(connect) is denied for
: VirtualHost 'test' on VirtualHostNode 'test'
>         at org.apache.qpid.server.model.AbstractConfiguredObject.authorise(AbstractConfiguredObject.java:2995)
>         at org.apache.qpid.server.model.AbstractConfiguredObject.authorise(AbstractConfiguredObject.java:2929)
>         at org.apache.qpid.server.virtualhost.AbstractVirtualHost.authoriseCreateConnection(AbstractVirtualHost.java:1144)
>         at org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.receiveOpenInternal(AMQPConnection_1_0Impl.java:970)
>         at org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.receiveOpen(AMQPConnection_1_0Impl.java:886)
>         at org.apache.qpid.server.protocol.v1_0.type.transport.Open.invoke(Open.java:274)
>         at org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.received(AMQPConnection_1_0Impl.java:499)
>         at org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.receive(AMQPConnection_1_0Impl.java:481)
>         at org.apache.qpid.server.protocol.v1_0.framing.FrameHandler.parse(FrameHandler.java:216)
>         at org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.lambda$received$11(AMQPConnection_1_0Impl.java:1320)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.received(AMQPConnection_1_0Impl.java:1295)
>         at org.apache.qpid.server.transport.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:134)
>         at org.apache.qpid.server.transport.NonBlockingConnection.processAmqpData(NonBlockingConnection.java:593)
>         at org.apache.qpid.server.transport.NonBlockingConnectionPlainDelegate.processData(NonBlockingConnectionPlainDelegate.java:58)
>         at org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:483)
>         at org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:270)
>         at org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:129)
>         at org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
>         at org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:354)
>         at org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
>         at org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message