qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1622) Add coverage reporting to CMake build
Date Mon, 23 Oct 2017 13:03:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215099#comment-16215099
] 

Alan Conway commented on PROTON-1622:
-------------------------------------

{code}
option(ENABLE_VALGRIND "Use valgrind to detect run-time problems" ON)
if (ENABLE_VALGRIND)
  if (NOT VALGRIND_EXE)
    message(STATUS "Can't locate the valgrind command; no run-time error detection")
  elseif (CMAKE_BUILD_TYPE MATCHES "Coverage")
    message(STATUS "Building for coverage analysis; no run-time error detection")
{code}

This is not in the pull request - I think some code didn't make it from your branch. I used
`git fetch apache pull/124/head:jd-coverage` to get the PR. That probably explains why it
doesn't work for me - I'm missing updates to one of the CMake files.

> Add coverage reporting to CMake build
> -------------------------------------
>
>                 Key: PROTON-1622
>                 URL: https://issues.apache.org/jira/browse/PROTON-1622
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.18.0
>            Reporter: Jiri Daněk
>            Assignee: Justin Ross
>            Priority: Minor
>              Labels: patch, testing
>             Fix For: proton-c-0.19.0
>
>
> This improvement is intended to cover
> * Reporting coverage from Python code
> * Upload of Python and C/C++ coverage data from Travis CI to codecov.io for easy viewing



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message