qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code
Date Tue, 24 Oct 2017 12:07:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216771#comment-16216771
] 

ASF GitHub Bot commented on PROTON-1651:
----------------------------------------

GitHub user jdanekrh opened a pull request:

    https://github.com/apache/qpid-proton/pull/127

    PROTON-1651 Fix typos found by the spellchecker

    > injecter  proton.Injecter
    * injector, maybe. this is public api, so probably should not be touched, though
    
    > Now that we've covered the basics with the archetypical hello world app, let's look
at some more interesting examples.
    
    * archetypal, maybe?
    * decreffed
    ** how many f's, proton has f and ff both
    
    > ractor = Reactor.wrap(self.reactor_impl)
    * intentional?
    
    I've been probably overzealous what I now realise is just british spelling. Found that
deserialised with s is just alternative spelling, I can revert these instances...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/qpid-proton jd_typos

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 3ee744ca62687a66178d32e36746930835ec7db5
Author: Jiri Danek <jdanek@redhat.com>
Date:   2017-10-24T06:49:17Z

    PROTON-1651 Fix typos found by the spellchecker

----


> Run spellchecker on proton-c code
> ---------------------------------
>
>                 Key: PROTON-1651
>                 URL: https://issues.apache.org/jira/browse/PROTON-1651
>             Project: Qpid Proton
>          Issue Type: Task
>    Affects Versions: proton-c-0.18.0
>            Reporter: Jiri Daněk
>            Priority: Minor
>
> I've noticed some typos. I believe systematic approach in trying to get rid of them is
in order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message