qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code
Date Tue, 24 Oct 2017 12:10:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216774#comment-16216774
] 

ASF GitHub Bot commented on PROTON-1651:
----------------------------------------

Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/127#discussion_r146538625
  
    --- Diff: proton-c/bindings/javascript/module.js ---
    @@ -327,7 +327,7 @@ Module.EventDispatch = new function() { // Note the use of new to
create a Singl
                  * actually free and remove the selectable is deferred until next
                  * time round the (internal JavaScript) event loop. This turned out
                  * to be necessary because in some cases the ws WebSocket library
    -             * calls the onclose callback (concurrently!!) before the onmessage
    +             * calls the on_close callback (concurrently!!) before the on_message
    --- End diff --
    
    couldn't find what are correct names for these callbacks, maybe I got it wrong


> Run spellchecker on proton-c code
> ---------------------------------
>
>                 Key: PROTON-1651
>                 URL: https://issues.apache.org/jira/browse/PROTON-1651
>             Project: Qpid Proton
>          Issue Type: Task
>    Affects Versions: proton-c-0.18.0
>            Reporter: Jiri Daněk
>            Priority: Minor
>
> I've noticed some typos. I believe systematic approach in trying to get rid of them is
in order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message