qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code
Date Tue, 24 Oct 2017 12:11:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216780#comment-16216780
] 

ASF GitHub Bot commented on PROTON-1651:
----------------------------------------

Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/127#discussion_r146538930
  
    --- Diff: proton-c/bindings/ruby/lib/reactor/container.rb ---
    @@ -155,7 +155,7 @@ def create_sender(context, opts = {})
             sender.source.address = opts[:source] if !opts[:source].nil?
             sender.target.address = target if target
             sender.handler = opts[:handler] if !opts[:handler].nil?
    -        sender.tag_generator = opts[:tag_generator] if !opts[:tag_gnenerator].nil?
    +        sender.tag_generator = opts[:tag_generator] if !opts[:tag_generator].nil?
    --- End diff --
    
    highlighting code change


> Run spellchecker on proton-c code
> ---------------------------------
>
>                 Key: PROTON-1651
>                 URL: https://issues.apache.org/jira/browse/PROTON-1651
>             Project: Qpid Proton
>          Issue Type: Task
>    Affects Versions: proton-c-0.18.0
>            Reporter: Jiri Daněk
>            Priority: Minor
>
> I've noticed some typos. I believe systematic approach in trying to get rid of them is
in order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message