qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitcher <...@git.apache.org>
Subject [GitHub] qpid-proton issue #128: PROTON-1342: CI on OS X
Date Mon, 06 Nov 2017 14:41:23 GMT
Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/128
  
    I like this latest version, but 2 remaining things:
    
    * Please, please rebase and squash this to be a single commit - this chain of development
makes no sense as part of the project history.
    * A niggle really - you didn't follow the existing formatting of the yaml file. Specifically
you indent follow on lists, this just pushes everything further right and makes it harder
to read long lines. The existing style is like this:
    ```yaml
    before_install:
    - eval ...
    - if ...
    - if ...
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message