qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1342) CI on OS X
Date Fri, 03 Nov 2017 15:03:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237701#comment-16237701
] 

ASF GitHub Bot commented on PROTON-1342:
----------------------------------------

Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/128
  
    A few points - 
    * I'm not sure how familiar you are with git/github: but there seem to be a lot of fairly
meaningless changes here. Could you squash all of these changes into a single change. That
would make it easier to see what's actually changed.
    * I think you've introduced way too many builds to the CI - do we really need to build
every possible version of Xcode? I'd prefer to pick just the current and earliest supported
version - that should suffice for CI, shouldn't it?
    * I don't think you need to introduce a conditional to the before_script. The purpose
of the QPID_PROTON_CMAKE_ARGS variable is to change exactly what you are changing - I think
you can set it for the new matrix elements you are introducing.


> CI on OS X
> ----------
>
>                 Key: PROTON-1342
>                 URL: https://issues.apache.org/jira/browse/PROTON-1342
>             Project: Qpid Proton
>          Issue Type: Task
>          Components: proton-c
>            Reporter: Justin Ross
>            Priority: Major
>              Labels: osx, testing
>             Fix For: proton-c-future
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message