qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1718) (Proton-J) Custom Sasl
Date Tue, 19 Dec 2017 17:20:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297103#comment-16297103
] 

Robbie Gemmell commented on PROTON-1718:
----------------------------------------

Copy of comment from https://github.com/apache/qpid-proton-j/pull/13, the bot didn't mirror
it since the JIRA key isn't in the PR title:
{quote}
My immediate reaction is that this isn't acceptable. It exposes various APIs that are considered
part of the implementation only, and then further exposes additional implementation detail
presumably to subclass it, which it similarly isn't intended for.

Given the general nature of the engines Sasl object/api, would I be right to assume the reason
you want this ability is mainly just due to limitations imposed from use within the Reactor?
If so perhaps theres a nicer reactor-only approach that can be explored, or alternatively
perhaps theres a neat way to tie it in with the existing layering exposed by TransportInternal
for similar reactor related layering reasons.
{quote}

> (Proton-J) Custom Sasl
> ----------------------
>
>                 Key: PROTON-1718
>                 URL: https://issues.apache.org/jira/browse/PROTON-1718
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: proton-j-0.24.0
>            Reporter: Tim Taylor
>              Labels: features
>
> I would like to be able to provide a custom SASL implementation for Proton-j to use instead
of being forced to use the default SaslImpl.java implementation.
> Ideally, code like below would be possible
> private class CustomSasl implements org.apache.qpid.proton.engine.Sasl
> {
> ...
> }
> ...
> ...
> //transport.sasl(...) saves the provided sasl implementation and uses it internally
> Sasl sasl = transport.sasl(new CustomSasl());
> Do you currently have a workaround that would allow me to use Proton-J this way?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message