qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim van der Riet (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPIDIT-61) Condense common code from the Python tests into a test module.
Date Fri, 26 Jan 2018 16:59:00 GMT

    [ https://issues.apache.org/jira/browse/QPIDIT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341274#comment-16341274
] 

Kim van der Riet commented on QPIDIT-61:
----------------------------------------

The above commit did some major refactoring in the (currently) 4 tests. A new module {{qit_common}} was
created, and the following were placed into it which is common between the test classes:

{{QitTestTypeMap}} which was previously in module test_type_map, is a parent class for the
test values used in a test;

{{QitCommonTestOptions}} contains the command-line options common to all tests;

{{QitTestCase}} contains the abstract parent class for all QIT test cases. It adds methods
which record the time taken for each test case;

{{QitTest}} is the abstract base class for the test itself. It handles common pre-test tasks
such as creating the shim map, creating the argparse object, modifying the shim map if needed
depending on the options selected, and detecting the broker connection properties to identify
the broker.

{{QitJmsTest}} is a specialized version of {{QitTest}} which also sets up a Java classpath
and handles shims which are embedded in a jar.

> Condense common code from the Python tests into a test module.
> --------------------------------------------------------------
>
>                 Key: QPIDIT-61
>                 URL: https://issues.apache.org/jira/browse/QPIDIT-61
>             Project: Apache QPID Interoperability Test Suite
>          Issue Type: Task
>          Components: AMQP Large Content Test, AMQP Types Test, JMS Headers and Properties
Test, JMS Message Test
>    Affects Versions: 0.1.0
>            Reporter: Kim van der Riet
>            Assignee: Kim van der Riet
>            Priority: Minor
>
> Each test was written independently of the others. While this is a quick way to start,
it has not lead to a lot of duplicated code and common patterns. It would help maintenance
and readability of the code if the common bits were placed into a test library.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message