qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1724) [ruby] early error in Container#listen is not handled correctly
Date Fri, 05 Jan 2018 16:36:01 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313402#comment-16313402
] 

ASF subversion and git services commented on PROTON-1724:
---------------------------------------------------------

Commit cd06716a08c936f5e7db053355a033b4af45529f in qpid-proton's branch refs/heads/go1 from
[~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=cd06716 ]

PROTON-1724: Revert "PROTON-1721 [ruby] resovler errors are not handled correctly"

This reverts commit c4d5fde71d925f3f44b0e29d672de7b039ee709f.

In the context of Ruby it is better to raise these exceptions immediately than to
bury them as events.


> [ruby] early error in Container#listen is not handled correctly
> ---------------------------------------------------------------
>
>                 Key: PROTON-1724
>                 URL: https://issues.apache.org/jira/browse/PROTON-1724
>             Project: Qpid Proton
>          Issue Type: Bug
>    Affects Versions: proton-c-0.18.1
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>
> Errors on listener are not handled correctly:
> on_open is called when it should not be - on an error only on_error should be called.
> errors before creation of the socket (e.g. DNS lookup error) are not reported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message