qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7873) Delete store notion confused
Date Thu, 01 Feb 2018 09:40:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348289#comment-16348289
] 

Alex Rudyy commented on QPID-7873:
----------------------------------

The changes made in commit [bce93dfb642ef30a87227377d71c588b084d7d04|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=bce93df]
committed against QPID-8066 fix the deletion of configuration and message stores. The {{onDelete}}
method expects that stores are closed. For non-provided stores, an {{IllegalStateException}}
is thrown on attempt to call {{onDelete}} when store is open. Though, there is a remaining
issue with calling {{onDelete}} on link and preferences store when VHN is deleted. For example,
if JDBC VHN having JDBC VH is deleted, the preferences and link tables are left over in the
database. When VHN deletion follows VH deletion, all tables are deleted.

> Delete store notion confused
> ----------------------------
>
>                 Key: QPID-7873
>                 URL: https://issues.apache.org/jira/browse/QPID-7873
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Keith Wall
>            Priority: Major
>             Fix For: Future
>
>
> org.apache.qpid.server.store.MessageStore#onDelete
> org.apache.qpid.server.store.DurableConfigurationStore#onDelete
> org.apache.qpid.server.protocol.v1_0.store.LinkStore#delete
> The Java Broker's delete store notion conflates the removal of the structures from the
store (e.g. the removal of a table from a RDBMS, for instance) with the destruction of the
store itself (e.g. removal of Derby or BDB files).  We are also unclear about whether we expect
a store to be in an open state when the store is deleted.
> This problem does not currently cause a functional defect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message