qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state
Date Thu, 22 Feb 2018 14:58:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372900#comment-16372900
] 

ASF GitHub Bot commented on QPID-7972:
--------------------------------------

Github user k-wall commented on the issue:

    https://github.com/apache/qpid-broker-j/pull/4
  
    Hello Olivier
    
    Thanks for the contribution.  It is much appreciated.
    
    I am not too uncomfortable with the idea of special casing of the state behaviour for
this one type of VirtualHostNode.
    
    I think in the long term, in general parent objects should have some way to react to the
state of the their child, but I think this would want to be done within the common mechanics
of AbstractConfiguredObject rather than applied piecemeal.   It would be useful to be able
to apply different rules - for instance a virtualhost might be considered critical whereas
a BrokerSyslogLogger not.   This would be a larger piece of work.
    
    I am looking for another way to solve your problem.   Looking at `BrokerImpl#performActivation`,
it currently checks the immediate decedents of the Broker if `broker.failStartupWithErroredChild`
is set.   We could alter this code so it can either check immediate descendants or the state
of the entire tree.  If the code had that ability would your use case by answered?
    



> Virtual Host Node should be in error state if the underlying Virtual Host is in error
state
> -------------------------------------------------------------------------------------------
>
>                 Key: QPID-7972
>                 URL: https://issues.apache.org/jira/browse/QPID-7972
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-6.1.4
>            Reporter: Adel Boutros
>            Priority: Major
>
> All details can be found here: http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message