qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata
Date Mon, 26 Feb 2018 15:05:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376996#comment-16376996
] 

ASF GitHub Bot commented on DISPATCH-918:
-----------------------------------------

Github user ganeshmurthy commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/261#discussion_r170619984
  
    --- Diff: tests/system_tests_autolinks.py ---
    @@ -53,17 +53,18 @@ def setUpClass(cls):
                 #
                 # Create a pair of default auto-links for 'node.1'
                 #
    -            ('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 'dir': 'in'}),
    -            ('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 'dir': 'out'}),
    +            ('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 'direction':
'in'}),
    +            ('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 'direction':
'out'}),
     
                 #
                 # Create a pair of auto-links on non-default phases for container-to-container
transfers
                 #
    -            ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2', 'dir': 'in',
 'phase': '4'}),
    -            ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3', 'dir': 'out',
'phase': '4'}),
    +            ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2', 'direction':
'in',  'phase': '4'}),
    +            ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3', 'direction':
'out', 'phase': '4'}),
     
                 #
                 # Create a pair of auto-links with a different external address
    +            # Leave the direction as dir to test backward compatibility.
    --- End diff --
    
    No there is not such a test. Thanks for pointing that out. I will add such a test to this
PR shortly.


> Improve router config consistency and metadata
> ----------------------------------------------
>
>                 Key: DISPATCH-918
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-918
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Justin Ross
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  All changes
must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can generate better
docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message