qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1758) [Python binding] Check message application property keys, convert binary to string
Date Fri, 02 Feb 2018 21:54:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350985#comment-16350985
] 

ASF subversion and git services commented on PROTON-1758:
---------------------------------------------------------

Commit ae3eaaa2e2351b29c23825d141ac9b5ba17cbdf6 in qpid-proton's branch refs/heads/master
from [~kpvdr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ae3eaaa ]

PROTON-1758: Change message application properties that are binary to unicode string; raise
error for other key types.


> [Python binding] Check message application property keys, convert binary to string
> ----------------------------------------------------------------------------------
>
>                 Key: PROTON-1758
>                 URL: https://issues.apache.org/jira/browse/PROTON-1758
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>            Reporter: Kim van der Riet
>            Assignee: Kim van der Riet
>            Priority: Minor
>
> The AMQP 1.0 specification requires message application property keys to be strings.
Currently the Python binding makes no type check on message application property key types.
Under Python 2, using the pattern
> {noformat}
> props['key'] = 'value'{noformat}
> results in the key being encoded as binary, whereas in Python 3, it is a unicode string.
While changing the pattern to
> {noformat}
> props[u'key'] = u'value'{noformat}
> is trivially easy and would work for both versions of Python, it would help usability
and AMQP wire correctness if the binding would check the key type and:
>  # if binary, convert to unicode string;
>  # if any other type, raise an exception
> before sending a message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message