qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY
Date Wed, 14 Feb 2018 06:44:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363553#comment-16363553
] 

ASF GitHub Bot commented on DISPATCH-926:
-----------------------------------------

GitHub user s1061123 opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/256

    DISPATCH-926: Fix offered capability encoding

    This code fix encoding of offered capability (symbol -> symbol[]), as OASIS AMQP1.0
spec.
    http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/s1061123/qpid-dispatch fix_offer_capability

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #256
    
----
commit bb4fdd646ecabd7858baf2d738c1feddf32d5e44
Author: Tomofumi Hayashi <tohayash@...>
Date:   2018-02-14T06:39:06Z

    DISPATCH-926: Fix offered capability encoding
    
    This code fix encoding of offered capability (symbol -> symbol[]),
    as OASIS AMQP1.0 spec.

----


> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY
> --------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-926
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-926
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Tomofumi Hayashi
>            Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], symbol array
as following: [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of qdrouterd.conf), qdrouterd
sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood.... Could you please double
check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, pn_connection_t
*conn, c
>      //
>      // Offer ANONYMOUS_RELAY capability
>      //
> +    pn_data_put_array(pn_connection_offered_capabilities(conn), false, PN_SYMBOL);
> +    pn_data_enter(pn_connection_offered_capabilities(conn));
>      pn_data_put_symbol(pn_connection_offered_capabilities(conn), pn_bytes(clen, (char*)
QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>      //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message