qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhardesty <...@git.apache.org>
Subject [GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Date Mon, 05 Mar 2018 22:12:26 GMT
Github user bhardesty commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/263#discussion_r172346629
  
    --- Diff: python/qpid_dispatch/management/qdrouter.json ---
    @@ -431,37 +431,100 @@
                         "description": "Time in seconds after which link state is declared
stale if no RA is received.",
                         "create": true
                     },
    -                "addrCount": {
    -                    "type": "integer",
    -                    "description":"Number of addresses known to the router.",
    -                    "graph": true
    -                },
    -                "linkCount": {
    +                "workerThreads": {
                         "type": "integer",
    -                    "description":"Number of links attached to the router node.",
    -                    "graph": true
    +                    "default": 4,
    +                    "description": "The number of threads that will be created to process
message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
    +                    "create": true
                     },
    -                "nodeCount": {
    -                    "type": "integer",
    -                    "description":"Number of known peer router nodes.",
    -                    "graph": true
    +                "debugDump": {
    +                    "type": "path",
    +                    "description": "A file to dump debugging information that can't be
logged normally.",
    --- End diff --
    
    OK, so essentially a core dump. I didn't get that at first. Anyways, I'd suggest the following
description (assuming of course that debugDump requires the absolute path, and that the path
is to a directory, not the name of the actual debug dump file):
    
    The absolute path to the location for debug dump files. If the router crashes, a debug
dump file is created in this directory to assist in troubleshooting the problem.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message