qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7873) [Broker-J] Delete store notion confused
Date Tue, 06 Mar 2018 13:57:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387812#comment-16387812

Alex Rudyy commented on QPID-7873:

I am not sure that we need separate methods for structure removal and destruction of the store.
The current responsibilities of onDelete/delete store methods is to perform the required clean
up on store destruction which includes the deletion of tables in case of JDBC store or files
removal in case of BDB/Derby/JSON. We do not invoke the cleanup methods in all scenarios.
Thus, we need to re-mediate it and reliably cleanup the stores on deletion of virtual host
nodes or/and virtual hosts

> [Broker-J] Delete store notion confused
> ---------------------------------------
>                 Key: QPID-7873
>                 URL: https://issues.apache.org/jira/browse/QPID-7873
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>            Priority: Major
>             Fix For: Future
> org.apache.qpid.server.store.MessageStore#onDelete
> org.apache.qpid.server.store.DurableConfigurationStore#onDelete
> org.apache.qpid.server.protocol.v1_0.store.LinkStore#delete
> The Java Broker's delete store notion conflates the removal of the structures from the
store (e.g. the removal of a table from a RDBMS, for instance) with the destruction of the
store itself (e.g. removal of Derby or BDB files).  We are also unclear about whether we expect
a store to be in an open state when the store is deleted.
> This problem does not currently cause a functional defect.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message