qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-8114) [Broker-J] Attempting to use an unknown filter type incorrectly causes connection closure with a decode error
Date Thu, 01 Mar 2018 09:33:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381738#comment-16381738
] 

Rob Godfrey commented on QPID-8114:
-----------------------------------

Attached a patch which I think would address this particular instance of the problem; however
it is a more general thing that we are handling unknown described types as a decoding error,
rather than higher up in the stack.  The patch provides the outlines of a generalized mechanism
for this, but we would need to go through all the "specialized" described types and fix them,
along with all the places in the codec where this sort of thing may occur

> [Broker-J] Attempting to use an unknown filter type incorrectly causes connection closure
with a decode error
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-8114
>                 URL: https://issues.apache.org/jira/browse/QPID-8114
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>            Reporter: Rob Godfrey
>            Priority: Major
>         Attachments: QPID-8114___[Broker-J]_Attempting_to_use_an_unknown_filter_type_incorrectly_causes_connect.patch
>
>
> As discovered in QPID-8113 if a client attempts to attach to a source using an unknown
filter type (i.e. an unrecognised descriptor) the broker responds with a decode error similar
to 
> {{[0x555941994670]:0 <- @close(24) [error=@error(29) [condition=:"amqp:decode-error",
description="Expected key type is 'Filter' but got 'DescribedType'"]]}}
> Instead the broker should simply fail to attach (i.e. attach with source=null) and then
immediately detach with a {{not-implemented}} error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message