qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1781) [c-proactor] fix mis-named netaddr functions
Date Tue, 06 Mar 2018 16:36:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388061#comment-16388061

Alan Conway commented on PROTON-1781:

commit 06c3d6e2f46811038853b95401cd017cb21e2713 (github/netaddr-names, netaddr-names)
Author: Alan Conway <aconway@redhat.com>
Commit: Alan Conway <aconway@redhat.com>

    PROTON-1781 [c-proactor] fix mis-named netaddr functions
    The old functions are deprecated but still present - old binaries can still be
    linked with new libraies, old source will fail to compile with a deprecation
    message unless -DPN_USE_DEPRECATED_API is present in CMAKE_C_FLAGS

> [c-proactor] fix mis-named netaddr functions 
> ---------------------------------------------
>                 Key: PROTON-1781
>                 URL: https://issues.apache.org/jira/browse/PROTON-1781
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.21.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>            Priority: Major
>             Fix For: proton-c-0.22.0
> The functions pn_netaddr_remote, pn_netaddr_local and pn_netaddr_listening do not follow
proton's naming conventions - the first part of the name should be the type of the first parameter
to the function. Rename as pn_transport_remote_addr, pn_transport_local_addr and pn_transport_listener_addr

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message