qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From p32blo <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...
Date Thu, 01 Mar 2018 10:32:38 GMT
GitHub user p32blo opened a pull request:

    https://github.com/apache/qpid-proton/pull/137

    [cpp] Fix update method missing 'name' variable

    The `name` property in the sender and receiver is not being updated correctly when passed
to the `open_sender` and `open_receiver`.
    
    Here is a simple example demonstrating the problem:
    ```cpp
    #include <proton/sender_options.hpp>
    #include <proton/receiver_options.hpp>
    #include <proton/container.hpp>
    
    #include <iostream>
    
    int main()
    {
        proton::container c;
    
        proton::sender_options so;
        proton::receiver_options ro;
    
        so.name("qpid");
        ro.name("qpid");
    
        proton::sender sender = c.open_sender("", so);
        proton::receiver receiver = c.open_receiver("", ro);
    
        std::cout << sender.name() << std::endl;
        std::cout << receiver.name() << std::endl;
    }
    ```
    The output is currently a random uuid, but it should be "qpid" in both cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/p32blo/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 69a9f91627ccc997337cab5f191f2d1c80ca10f3
Author: André Oliveira <andreoliveira@...>
Date:   2018-03-01T10:15:30Z

    [cpp] Fix update method missing 'name' variable

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message