qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
Date Fri, 27 Apr 2018 16:46:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456721#comment-16456721
] 

ASF GitHub Bot commented on DISPATCH-960:
-----------------------------------------

Github user fgiorgetti commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/294#discussion_r184743211
  
    --- Diff: src/amqp.c ---
    @@ -73,11 +76,30 @@ const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = "amqp:frame-size-too-smal
     const char * const QD_AMQP_PORT_STR = "5672";
     const char * const QD_AMQPS_PORT_STR = "5671";
     
    +const char * const QD_AMQP_DFLT_PROTO = "tcp";
    +
     int qd_port_int(const char* port_str) {
         if (!strcmp(port_str, QD_AMQP_PORT_STR)) return QD_AMQP_PORT_INT;
    --- End diff --
    
    You're right. Maybe I should submit a new PR without the strcmp, as service name is now
being resolved when strtoul returns 0. And also, using static values for amqp/amqps can also
be a problem, in case someone changes the default values at /etc/services (no supposed to
happen, but it is possible).


> TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
> ---------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-960
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-960
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>            Reporter: Fernando Giorgetti
>            Priority: Major
>         Attachments: dispatch-960-reproducer.tar.gz
>
>
> The default configuration for the dispatch router contains a default listener set up
to use 'port: amqp'.
> If you change the default listener to use 'http: yes' and starts the router, it causes
an issue as the service name (amqp) is not resolved, and so the router attempts to listen
to port 0 (random), causing an unpredictable behavior.
>  
> A reproducer is attached to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message