qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grs <...@git.apache.org>
Subject [GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Date Thu, 10 May 2018 15:33:46 GMT
Github user grs commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/303#discussion_r187367734
  
    --- Diff: src/router_core/connections.c ---
    @@ -473,7 +474,8 @@ void qdr_link_second_attach(qdr_link_t *link, qdr_terminus_t *source,
qdr_termin
         action->args.connection.link   = link;
         action->args.connection.source = source;
         action->args.connection.target = target;
    -    qdr_action_enqueue(link->core, action);
    +    if (link)
    --- End diff --
    
    I wonder if the test might be better done in AMQP_link_attach_handler in router_node.c?
That is the only place that calls the method, and is the one that retrieves the null context.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message