qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-8186) Incorrect exception handling fails to build on GCC 8
Date Sun, 13 May 2018 16:05:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473539#comment-16473539
] 

ASF subversion and git services commented on QPID-8186:
-------------------------------------------------------

Commit 8b09d246f2529ea59809cac743e55af3920b4895 in qpid-cpp's branch refs/heads/master from
[~chris.richardson]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=8b09d24 ]

QPID-8186 Use const ref when catching exceptions


> Incorrect exception handling fails to build on GCC 8
> ----------------------------------------------------
>
>                 Key: QPID-8186
>                 URL: https://issues.apache.org/jira/browse/QPID-8186
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: qpid-cpp-1.38.0
>         Environment: Gentoo x64, GCC 8.1
>            Reporter: Chris Richardson
>            Priority: Major
>             Fix For: qpid-cpp-1.39.0
>
>
> [ 22%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp: In member
function ‘bool qpid::sys::SocketAddress::isComparable(const qpid::sys::SocketAddress&)
const’:
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
error: catching polymorphic type ‘class qpid::Exception’ by value [-Werror=catch-value=]
>  } catch (Exception) {
>  ^~~~~~~~~
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
error: catching polymorphic type ‘class qpid::Exception’ by value [-Werror=catch-value=]
>  } catch (Exception) {
>  ^~~~~~~~~
>  
>  
> these "catch (Exception)" statements would better be const ref, which would also fix
the build failure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message